Initial implementation#1
Merged
Merged
Conversation
mdnix
added
bump:minor
|
🚀 This PR has been released as Triggering workflows 🛠️ Auto tagging enabled with label |
mdnix
force-pushed
the
init-implementation
branch
from
20127fc to
c9f44d3
Compare
mdnix
force-pushed
the
init-implementation
branch
from
c9f44d3 to
0dc2a21
Compare
simu
reviewed
May 29, 2026
Collaborator
Author
|
@simu Applied the suggestions, thanks! Also there's no point in having the logic in lib for this, moved it out of there. |
simu
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog.