[Hackathon] hiten: add typed FreshnessProof model#48
Open
Hiten0305l wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a focused follow-up to my previous hackathon PR (#39), implementing the reviewer-suggested
FreshnessProofAPI improvement after the DataFacts work from #31 was merged.This PR promotes
FreshnessProoffrom a plugin-local implementation incid_facts.pyto a first-class shared type innest_core.typesand updates the mergedcid_factsimplementation to use the shared model.What
FreshnessProofas a shared model innest_core.types.cid_factsimplementation to use the shared model instead of maintaining a plugin-local definition.nest_core.types.Why
Previously,
FreshnessProofwas defined only insidecid_facts.py, making it an implementation detail of a single plugin.Promoting it to
nest_core.typesmakes it:This follows the reviewer suggestion to promote
FreshnessProofinto a shared typed model while keeping the change small and focused.Scope
This PR is intentionally limited to the
FreshnessProofAPI improvement.Verification
make ci-local