Skip to content

Add ICMP time exceeded support#195

Open
Karen-Schoener wants to merge 1 commit into
prometheus-community:mainfrom
Karen-Schoener:add-icmp-time-exceeded-support
Open

Add ICMP time exceeded support#195
Karen-Schoener wants to merge 1 commit into
prometheus-community:mainfrom
Karen-Schoener:add-icmp-time-exceeded-support

Conversation

@Karen-Schoener
Copy link
Copy Markdown

@Karen-Schoener Karen-Schoener commented Apr 28, 2026

Allow pro-bing library to receive and process ICMP time exceeded messages.

Add new callback OnTimeExceeded to handle ICMP Type 11 (Time Exceeded) events.

This is useful when you want to catch ICMP time exceeded messages, in order to implement traceroute-like tools.

Fixes #194

@Karen-Schoener Karen-Schoener marked this pull request as draft April 28, 2026 12:14
@Karen-Schoener Karen-Schoener force-pushed the add-icmp-time-exceeded-support branch 4 times, most recently from 18773bd to a7bd4dd Compare April 28, 2026 20:04
@Karen-Schoener Karen-Schoener marked this pull request as ready for review April 28, 2026 21:30
@Karen-Schoener
Copy link
Copy Markdown
Author

Tested on windows 11 (with firewall configured to allow time exceeded):

  • tested ipv4 and ipv6 ping command. Verified successful icmp reply received.
  • tested ipv4 and ipv6 ping command with low TTL specified. Verified ping command resported: Time to live exceeded

Commands run on windows 11:

.\ping.exe -c 3 -l 255 --privileged -Q 0 <ipv6-ip>
.\ping.exe -c 3 -l 1     --privileged -Q 0 <ipv6-ip>

Tested on fedora VM.

  • tested ipv4 and ipv6 ping command. Verified successful icmp reply received.
  • tested ipv4 and ipv6 ping command with low TTL specified. Verified ping command resported: Time to live exceeded

Command run on fedora:

sudo ./ping -c 5 -l 255 --privileged <ipv4-ip>
sudo ./ping -c 5 -l 7   --privileged <ipv4-ip>

Copy link
Copy Markdown
Contributor

@Hipska Hipska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, just a minor suggestion to keep things simple..

Comment thread ping.go Outdated
Fixes prometheus-community#194

Signed-off-by: Karen Schoener <karen.schoener@ibm.com>
@Karen-Schoener Karen-Schoener force-pushed the add-icmp-time-exceeded-support branch from a7bd4dd to e3fd564 Compare May 5, 2026 13:39
@Karen-Schoener
Copy link
Copy Markdown
Author

@Hipska thanks very much for the review and approval!

Just wanted to check in on the next steps... Does this PR require approval from a second maintainer, or is the PR good to go?

Thanks very much, Karen

@Hipska
Copy link
Copy Markdown
Contributor

Hipska commented May 6, 2026

Yes, since I'm not an official maintainer 😉

@Karen-Schoener
Copy link
Copy Markdown
Author

Hi, tagging @SuperQ and @metalmatze to request a review of this PR from one of the maintainers of pro-bing.

This PR allows the pro-bing library to receive and process ICMP time exceeded messages.

When you get a chance, it would be great to hear feedback on the PR. Thanks very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add ICMP time exceeded support

2 participants