Add ICMP time exceeded support#195
Conversation
18773bd to
a7bd4dd
Compare
|
Tested on windows 11 (with firewall configured to allow time exceeded):
Commands run on windows 11: Tested on fedora VM.
Command run on fedora: |
Hipska
left a comment
There was a problem hiding this comment.
Looks fine, just a minor suggestion to keep things simple..
Fixes prometheus-community#194 Signed-off-by: Karen Schoener <karen.schoener@ibm.com>
a7bd4dd to
e3fd564
Compare
|
@Hipska thanks very much for the review and approval! Just wanted to check in on the next steps... Does this PR require approval from a second maintainer, or is the PR good to go? Thanks very much, Karen |
|
Yes, since I'm not an official maintainer 😉 |
|
Hi, tagging @SuperQ and @metalmatze to request a review of this PR from one of the maintainers of pro-bing. This PR allows the pro-bing library to receive and process ICMP time exceeded messages. When you get a chance, it would be great to hear feedback on the PR. Thanks very much! |
Allow pro-bing library to receive and process ICMP time exceeded messages.
Add new callback OnTimeExceeded to handle ICMP Type 11 (Time Exceeded) events.
This is useful when you want to catch ICMP time exceeded messages, in order to implement traceroute-like tools.
Fixes #194