This repository was archived by the owner on Aug 13, 2019. It is now read-only.
add prefixCompressedPostings#672
Open
naivewong wants to merge 2 commits into
Open
Conversation
naivewong
force-pushed
the
roaring16postings
branch
from
b504c5d to
4bf1288
Compare
brian-brazil
reviewed
Aug 5, 2019
Contributor
|
once this is ready lets run a Prombench test and add some relevant dashboard to the Prombench grafana dashboards to see the difference in size and performance. |
codesome
reviewed
Aug 6, 2019
codesome
left a comment
codesome
left a comment
Contributor
There was a problem hiding this comment.
This is for the writing part. Taking a look at the reading part next.
naivewong
force-pushed
the
roaring16postings
branch
from
4bf1288 to
5308b1f
Compare
codesome
reviewed
Aug 6, 2019
naivewong
force-pushed
the
roaring16postings
branch
2 times, most recently
from
5e316a3 to
06eee5b
Compare
codesome
reviewed
Aug 6, 2019
codesome
left a comment
codesome
left a comment
Contributor
There was a problem hiding this comment.
Mostly nits. I need a couple of more scans to do before I am done.
Signed-off-by: naivewong <867245430@qq.com>
naivewong
force-pushed
the
roaring16postings
branch
2 times, most recently
from
00903c0 to
8bac3f8
Compare
codesome
reviewed
Aug 12, 2019
naivewong
force-pushed
the
roaring16postings
branch
3 times, most recently
from
2053a33 to
292f4ee
Compare
codesome
reviewed
Aug 13, 2019
codesome
left a comment
codesome
left a comment
Contributor
There was a problem hiding this comment.
Some nits. I think we are good to test it on prombench now.
@krasi-georgiev how can we add new panels in the dashboard? We could use one for prometheus_tsdb_storage_blocks_bytes to check the size of blocks. For query perf we already have many panels needed.
Signed-off-by: naivewong <867245430@qq.com>
naivewong
force-pushed
the
roaring16postings
branch
from
292f4ee to
dadf7ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
prefixCompressedPostings corresponds to the roaring16postings in this doc.