Conversation
bwplotka
changed the title
4f9eb07 to
03c37e3
Compare
bwplotka
changed the title
bwplotka
changed the title
bwplotka
changed the title
033d077 to
704dee5
Compare
|
FYI: We met for 1h with the delta WG (@ArthurSens @carrieedwards @fionaliao @ywwg) for an initial discussion around this proposal decisions. Thanks for this productive time! Here are some notes:
Also updated proposal today with some learnings. Finally proposed a single feature flag for this work ( Still lots of TODOs and anyone is welcome to help! |
Signed-off-by: bwplotka <bwplotka@gmail.com>
ywwg
left a comment
ywwg
left a comment
There was a problem hiding this comment.
Thank you for this proposal! I added a bunch of comments, some of which are answered by the paragraph right after the comment 😅 . I think my main concern is nailing down the Goals section. This is not at all to question whether we should do the work, just that I think our statement of intent needs to be unequivocable.
|
This makes a lot of sense to me. I think performance/benchmarks are probably the biggest potential blocker. |
|
Back from some PTO/leave, will try to address comments and finalize interface and TSDB piece soon |
There was a problem hiding this comment.
I'm adding just a few stylish/correction comments. I'm midway through the document and still haven't reviewed the proposed interfaces.
Regarding the CT vs ST discussion, I see the point that we'll always have more new users than old ones, but I feel like the CT terminology is so ingrained in the ecosystem that even if we change it now, people will continue to call it CT. Of course this is based on "voices in my head" and there's no real confirmation that this is gonna happen in the future 😅
bwplotka
left a comment
bwplotka
left a comment
There was a problem hiding this comment.
I addressed first pass, thanks for reviews!
Incorporate feedback from reviewers: update delta support goal to MUST, add section explaining unknown start-time resets mapping to 0 at ingestion, clarify storage flexibility across metric types, fix broken markdown links, and correct multiple minor typos. Signed-off-by: bwplotka <bwplotka@gmail.com>
Signed-off-by: bwplotka <bwplotka@gmail.com>
Signed-off-by: bwplotka <bwplotka@gmail.com>
|
Addressed all comments, plus it's already implemented 🎉 Waiting for formal approvals as discussed in Slack |
Co-authored-by: David Ashpole <dashpole@google.com> Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
krajorama
left a comment
krajorama
left a comment
There was a problem hiding this comment.
Looking good, I think the unknown start time is the sticking point.
Co-authored-by: George Krajcsovits <krajorama@users.noreply.github.com> Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
|
Per our meeting today, we will be updating this proposal with some clarifications and additions:
|
Signed-off-by: Owen Williams <owen.williams@grafana.com>
Signed-off-by: Owen Williams <owen.williams@grafana.com>
add detail about interaction with zero injection
|
ok I merged in the last changes talking about zero injection, are we good to merge? |
|
I found some nits on https://github.com/prometheus/proposals/pull/87/changes#r3501661834 also curious about #60 (comment) - even if we don't plan to decide, let's state so (I might have lost context, need to check what's the latest 🙈 ) |
Co-authored-by: George Krajcsovits <krajorama@users.noreply.github.com> Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
Signed-off-by: bwplotka <bwplotka@gmail.com>
Signed-off-by: bwplotka <bwplotka@gmail.com>
Signed-off-by: bwplotka <bwplotka@gmail.com>
Signed-off-by: bwplotka <bwplotka@gmail.com>
|
thanks for clarifying the zero-injection updates |
8 participants
As discussed in various places (e.g. prometheus/prometheus#17036 (comment) and delta WG) we decided to create a formal proposal on how CT/ST native Prometheus storage could look like and how to make it useful (unblock) delta temporality.