feat: load legacy cosmetics dynamically#38
Conversation
|
@copilot tell me if I missed anything |
You were mainly missing input sanitization for the dumped IDs (e.g. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
I said tell me if I missed anything not do it for me ._. |
|
yknow what this is ready for review |
|
please squash |
|
I am confused as to why we added kotlin too. |
|
Need the package to be more strict. Something like |
| return current == Windows | ||
| } | ||
| @JvmStatic | ||
| fun isOnPosix(): Boolean { |
Because essential bundles kotlin libs and I didn't want to deal with Java |
I'm looking at the Kotlin code, and this is literally more confusing than Java. There is no good reason for adding it. This is a Java project, let's keep it that way. |
d19799f to
e1a64c3
Compare
|
As it turns out the UUIDs are some of the current cosmetics (i.e. the cherry blossom cape) |
|
Kotlin is absolutely unacceptable. I do not want to see a single trace of it! |
prometheus/essential/cosmetics.jsonESSENTIAL_PURCHASE_CONFIRMATIONand the couple of UUIDs in the json filedumps/essentialtoessential/dumpsstudio.dreamys.prometheus.essentialJson file:
