fix(fmodata): navigate() includes parent table when defaultSelect is schema #108
+89
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
…schema Fix #107: navigation context wasn't propagated when defaultSelect was "schema" or object because list() returned early before reaching the navigation propagation code. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
eluce2
force-pushed
the
01-27-fix_fmodata_navigate_includes_parent_table_when_defaultselect_is_schema
branch
from
1568cee to
e3469d5
Compare
@proofkit/better-auth
@proofkit/cli
create-proofkit
@proofkit/fmdapi
@proofkit/fmodata
@proofkit/typegen
@proofkit/webviewer
commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #107: navigation context wasn't propagated when defaultSelect was
"schema" or object because list() returned early before reaching the
navigation propagation code.
Co-Authored-By: Claude Opus 4.5 noreply@anthropic.com
Note
Fixes missing navigation context when listing from a navigated
EntitySetwithdefaultSelectset to"schema"or a select object.entity-set.ts: after applying default selects, propagatenavigationmetadata onto the selectedQueryBuilderso URLs include the parent path (e.g.,/contacts/users), and keep defaulttop(1000)behaviornavigate.test.tsfor issue fmodata: navigate() doesn't include parent table in URL path #107 coveringdefaultSelect='schema'navigation path inclusion with and without filtersscripts/test-crossjoin.ts: stricter env checks, trailing slash handling, and logging tweaks@proofkit/fmodatapatch releaseWritten by Cursor Bugbot for commit e3469d5. This will update automatically on new commits. Configure here.