feat(PFW): implement find_candidate_path and is_duplicate_path #234
Merged
Conversation
tamaralipows
force-pushed
the
split-routing/tnl/ENG-5854-probe-amount-and-impact
branch
2 times, most recently
from
b7756e3 to
4f20708
Compare
tamaralipows
force-pushed
the
split-routing/dc/ENG-5855-find-candidate-path
branch
from
64593da to
00f1fad
Compare
Troshchk
reviewed
Jun 4, 2026
Contributor
Troshchk
left a comment
Troshchk
left a comment
There was a problem hiding this comment.
Only one q from my side
louise-poole
reviewed
Jun 4, 2026
Collaborator
louise-poole
left a comment
louise-poole
left a comment
There was a problem hiding this comment.
Thanks! Looks good - mainly some small comments, plus I agree with what @Troshchk said.
louise-poole
approved these changes
Jun 5, 2026
Collaborator
louise-poole
left a comment
louise-poole
left a comment
There was a problem hiding this comment.
A veeeery tiny comment from me, otherwise approved!
tamaralipows
force-pushed
the
split-routing/tnl/ENG-5854-probe-amount-and-impact
branch
3 times, most recently
from
02f0623 to
4ac233d
Compare
Base automatically changed from
split-routing/tnl/ENG-5854-probe-amount-and-impact
to
main
June 5, 2026 13:18
Troshchk
force-pushed
the
split-routing/dc/ENG-5855-find-candidate-path
branch
from
9acdeec to
86111f2
Compare
Done: - Adds two Frank-Wolfe path-discovery primitives to PathFrankWolfeAlgorithm: find_candidate_path and is_duplicate_path - Also replaces MarketOverrides::with_zero_gas(id, sim) with with_zero_gas(id): the old form required cloning the degraded sim out of the map to pass it back in; the new form removes the entry, wraps it, and reinserts — no clone, same intent. Took 1 hour 17 minutes
Troshchk
force-pushed
the
split-routing/dc/ENG-5855-find-candidate-path
branch
from
86111f2 to
3d565a2
Compare
No API Breaking Changes DetectedThe PR title signals breaking changes, but |
tamaralipows
approved these changes
Jun 5, 2026
Contributor
tamaralipows
left a comment
tamaralipows
left a comment
There was a problem hiding this comment.
Thank you! Looks good!
|
This PR is included in version 0.76.0 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done: