refactor: split HopDescriptor into descriptor and SimulatedHop#235
Merged
Conversation
tamaralipows
force-pushed
the
split-routing/tnl/hop-descriptor-amounts
branch
from
aad6795 to
95d07ef
Compare
louise-poole
approved these changes
Jun 5, 2026
Collaborator
louise-poole
left a comment
louise-poole
left a comment
There was a problem hiding this comment.
YESSS!! A thing of beauty 😍
dianacarvalho1
approved these changes
Jun 5, 2026
Collaborator
dianacarvalho1
left a comment
dianacarvalho1
left a comment
There was a problem hiding this comment.
🧹 🧹 💅🏼 💅🏼 thank you @tamaralipows!
tamaralipows
force-pushed
the
split-routing/tnl/hop-descriptor-amounts
branch
from
95d07ef to
916af5b
Compare
…rapper Separates simulation results (amount_out, gas) from the hop topology (component_id, token_in, token_out). This makes it clear at the type level which functions need simulation data and which only need routing descriptors, and eliminates the Option unwrapping that was needed when both lived on the same struct. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Add Clone derive to SimulatedHop, fix field access through descriptor in validate_token_cycles, add test helper with_amounts, and regenerate OpenAPI spec. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
tamaralipows
force-pushed
the
split-routing/tnl/hop-descriptor-amounts
branch
from
c6d43fe to
aa9a0c4
Compare
|
This PR is included in version 0.75.3 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separates simulation results (amount_out, gas) from the hop topology (component_id, token_in, token_out). This makes it clear at the type level which functions need simulation data and which only need routing descriptors, and eliminates the Option unwrapping that was needed when both lived on the same struct.