Fix to enable deletion of files in stream memory zips.#1
Open
Fix to enable deletion of files in stream memory zips.#1
Conversation
prot0man
force-pushed
the
330_stream_zip_delete_fix
branch
2 times, most recently
from
f288a52 to
b8c45d8
Compare
Had to add function that achieved the zip_move_files for an in memory buffer and change some of the internal functions to take objects that provided enough context information to operate on an in memory archive or disk-backed archive.
prot0man
force-pushed
the
330_stream_zip_delete_fix
branch
from
b8c45d8 to
5808891
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes result in the file actually successfully being deleted, but when you unzip the resulting zip, the are CRC warnings.