Refactor/configuration mechanism#68
Open
stanlou wants to merge 2 commits intorefactor--protokit-native-modules-configurationfrom
Open
Refactor/configuration mechanism#68stanlou wants to merge 2 commits intorefactor--protokit-native-modules-configurationfrom
stanlou wants to merge 2 commits intorefactor--protokit-native-modules-configurationfrom
Conversation
rpanic
changed the base branch from
develop
to
refactor--protokit-native-modules-configuration
rpanic
requested changes
Mar 26, 2026
| @@ -0,0 +1,24 @@ | |||
| export const config = { | |||
Member
There was a problem hiding this comment.
I don't like this at all actually, I think we should just inline all of these values. This is because here you have no type checking directly and code suggetions (which are actually pretty big feature if you don't know what you can configure and what not)
Member
There was a problem hiding this comment.
I understand why you did, and ideally I'd like something like this, but in this case we should move the entire config here for it to make sense.
But this then leads to us creating 3 new files so imo we should just inline stuff for now
| host: process.env.OPEN_TELEMETRY_METRICS_HOST ?? "localhost", | ||
| port: Number(process.env.OPEN_TELEMETRY_METRICS_PORT), | ||
| appendTimestamp: true, | ||
| export const createMetricsSequencerModulesConfig = ( |
Member
There was a problem hiding this comment.
Yeah this too, it's the same pattern as default modules again...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #62