ci: rebuild dist artifacts on release-please PRs#77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
release-please bumps versions in source files (options.sh, docs/*.adoc) but dist/ artifacts (bundled binaries, manpages) are not rebuilt. This adds a
rebuild-distjob to the CD workflow that detects release-please branches, rebuilds dist, and pushes the updated artifacts.How it works
After the
release-pleasejob runs, therebuild-distjob:git ls-remote.cachix/install-nix-action.nix develop --command make build NAME=<component>, and pushes any dist changes.This is safe against release-please force-pushes because the job runs sequentially after release-please (
needs: release-please) and the workflow uses a concurrency group that prevents parallel runs.Note on GITHUB_TOKEN
Pushes made with the default
GITHUB_TOKENwill not re-trigger CI on the release-please PR. If CI validation of the rebuilt dist artifacts is needed, a GitHub App token would be required instead.