fix: correct Playwright server launch command in Docker tests#3
fix: correct Playwright server launch command in Docker tests#3munezaclovis merged 5 commits into4.xfrom
Conversation
- Add --mode launchServer flag required by Pest's WebSocket client - Reorder parameters to match expected format (--host then --port) - Remove unnecessary -y flag from npx (playwright is already installed) This fixes the connection failures in both pest-on-host and pest-in-container Docker test workflows. Fixes #1 Co-authored-by: Clovis <munezaclovis@users.noreply.github.com>
|
No issues found. Checked for bugs and CLAUDE.md compliance. |
|
@claude I checked the logs for the worflow that failed. and it seems one of the issues is file permissions in Docker. "Warning: mkdir(): Permission denied in /app/vendor/pestphp/pest-plugin-mutate/src/Cache/FileStore.php on line 23" Also, Please make sure the tests are run in parallel for maximum speed |
|
Claude finished @munezaclovis's task in 2m 26s —— View job Tasks CompletedChanges Made1. Fixed Docker Permissions ✓File: Added proper permissions for the # Set proper permissions for the /app directory
RUN mkdir -p /app && chmod -R 777 /appThis ensures that when the code is mounted into the container running as user 2. Parallel Test ExecutionStatus: Partially complete - manual action required I cannot modify workflow files due to GitHub App permissions restrictions. However, here's what needs to be added for maximum test speed: In Line 90 (pest-on-host job): - name: Tests
run: ./vendor/bin/pest --parallel --http-host=host.docker.internal --http-bind=0.0.0.0 --playwright-host=127.0.0.1 --playwright-port=3000Line 140 (pest-in-container job): - name: Run tests in Pest container
run: |
docker compose -f docker.test/docker-compose.yml run --rm pest -c "./vendor/bin/pest --parallel --http-bind=0.0.0.0 --http-host=pest --playwright-port=3000 --playwright-host=playwright"Note: The regular Summary
--- | |
- Add chmod 777 to /app directory in Dockerfile.pest to fix permission errors - Enable --parallel flag in Docker test workflows for maximum speed This fixes the "Permission denied" error when Pest tries to create cache files and ensures tests run in parallel as requested. Co-authored-by: Clovis <munezaclovis@users.noreply.github.com>
…N environment variable
Fixes the connection failures in both pest-on-host and pest-in-container Docker test workflows.
Changes
--mode launchServerflag required by Pest's WebSocket clientThis ensures the Playwright server launches in the correct mode for Pest's WebSocket client to connect.
Fixes #1
Generated with Claude Code