Add version of mmcedrv with FHI integrated: mmcefhi - #1
Open
rickgaiser wants to merge 5 commits into
Open
Conversation
rickgaiser
marked this pull request as draft
January 23, 2025 20:33
rickgaiser
marked this pull request as ready for review
March 2, 2025 20:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just wanted to share with you my current approach to using mmcedrv in neutrino.
Basically I've merged fhi_mmce and mmcedrv into 1 driver. This reduced the needed modules by 1, and also reduces the size.
Current issues:
-I../../../apps/neutrino/iop/common/but this obviously only works for me.Please let me know what you think of this approach and if you have ideas on how to solve the above issues.