Conversation
- Restore original 0000000001_setup.sql (revert in-place edits) - Add 0000000003_trace_context.sql for context propagation - Update instrumentation peer dependency to require pgconductor-js > 0.1.0 - Update CLAUDE.md with migration policy (never edit existing migrations)
The trace_context migration was incorrectly rewriting the invoke and invoke_batch functions with different logic. This fix preserves all original logic (supersede pattern, singleton throttle/debounce, etc.) and only adds the trace_context column where needed.
Instead of exporting test fixtures from pgconductor-js, copy a self-contained version into the instrumentation package. Simplified to not depend on internal pgconductor-js modules.
Update PgConductorMetrics methods to accept a single object argument instead of positional parameters for better clarity and consistency. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The invoke function was being created in migration 1 without trace_context, then migration 3 tried to drop and recreate it with trace_context. This caused function ambiguity errors when calling invoke with named parameters. Fix by adding trace_context to the base migration (table, type, and functions) and using exception handling in migration 3 for existing deployments. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…biguity" This reverts commit 555830f.
Use dynamic DROP to find and remove the 9-parameter invoke function before creating the new 10-parameter version. Also add exception handling for ALTER TYPE to make the migration idempotent. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.