Fix ldap check#158
Closed
usmannsiddiqui wants to merge 36 commits into
Closed
Conversation
- Fill in all test cases using WebMock to stub HTTP responses - Fix RSpec.describe class name and capitalization - Fix auth header from Bearer token to X-API-KEY
Adds CommitteeData::EtdaImporter with import_all and import_for_faculty methods. Iterates over all faculty, calls the ETDA API client, and creates committee records. Error handling and tests still in progress.
- Add CommitteeData::EtdaImporter.new.import_all call to integrate method - Pass faculty object directly to import_for_faculty instead of access_id - Move import_for_faculty to private and fix access_id references
…nstead of a hash - Rename job to 'Committee Integration' - Use send(:name) in spec to test private method
- Fix stage_of_completion: 'In Progress' -> 'In Process' to match Activity Insight's valid dropdown values; add 'Withdrew' support - Add role_other_explanation and type_other_explanation DB columns for when role/type maps to 'Other' in Activity Insight - Improve map_type_of_work to use role context and handle more degree types (undergraduate, postdoc, honors) - Emit <ROLE_OTHER> and <TYPE_OTHER> XML tags when explanations present - Update all related specs
- Strip BOM from uploaded CSV to handle Excel exports - Fix error message typo: 'Usernames' -> 'Username' - Add CENTRAL_LDAP_HOST and CENTRAL_LDAP_PORT to .envrc.example
Jesse LE (jlandiseigsti)
left a comment
Jesse LE (jlandiseigsti)
left a comment
There was a problem hiding this comment.
The changes for the commit "Fix LDAP Check CSV parsing for Excel-exported files", which is the focus of the pull request, look good. However, this PR has lots of other commits that are duplicated by PR #152. You don't want the same commits or code changes in multiple PRs, and you don't want code changes in a PR that aren't related to the purpose of the PR.
After you get the changes Alex requested in PR 152 resolved and merged in, we'll return to this PR. At that point, there should only be one commit, and two files changed...much easier to review.
Alex Kiessling (ajkiessl)
changed the base branch from
main
to
etda-post-receiver
Joao Vitor Barros da Silva (jvitorbarros15)
changed the base branch from
etda-post-receiver
to
main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Strip BOM from uploaded CSV to handle Excel exports and fixed error message typo: 'Usernames' -> 'Username'
added these credentials: Add CENTRAL_LDAP_HOST and CENTRAL_LDAP_PORT to .envrc.example.