135 create users fixes#168
Open
Joao Vitor Barros da Silva (jvitorbarros15) wants to merge 2 commits into
Open
Conversation
Contributor
Joao Vitor Barros da Silva (jvitorbarros15)
commented
Apr 30, 2026
Joao Vitor Barros da Silva (jvitorbarros15)
commented
- Fixed header validation and create user integration
- Fix bom encoding in csv
) Validate that required columns (Username, First Name, Last Name, Email) exist in the CSV before processing rows. Raises a descriptive error listing missing columns instead of crashing with NoMethodError on nil. Add 'bom|utf-8' encoding to CSV.foreach so Excel-exported files with BOM are handled correctly (same class of bug fixed in PR #163 for LDAP Check).
Alex Kiessling (ajkiessl)
approved these changes
May 20, 2026
Contributor
Alex Kiessling (ajkiessl)
left a comment
Alex Kiessling (ajkiessl)
left a comment
There was a problem hiding this comment.
This LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.