Open Access Version Guesser#1969
Open
Alex Kiessling (ajkiessl) wants to merge 27 commits into
Open
Conversation
…classes and pulling the score calculator rules from config/open_access_version_guessing_rules.csv. Adds tests for the version guesser class. Still need tests for the score calculator.
…ssVersionScoreCalculator. Adds fixtures for real score calculation and testing as many permutations of the score calculator as possible
… with arxiv watermark. - Removes docx fixture file. No need to test real fixture for non-pdf blocking - Modularized: OpenAccessVersion module - Started adding in ExifTool version checking code. Includes 'exiftool_vendored' gem
… very obvious logic.
… so this module is cleaner. Updates tests. Adds pdf? and docx? methods to FileResource.
…controller. Tests
Alex Kiessling (ajkiessl)
changed the title
…nknown if exif checking finds latex indicators, or if a version score cannot be calculated. Fixed up the version guesser tests, and any tests that now need to test for the unknown value.
… works better with some of the gems being used. Version guessing works end-to-end, but now I need to fix some things up and fix tests.
… version is an open access upload. Fixes tests so they do not use IO file object during version guessing. Now use Tempfile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1950
Implements the open access version guessing feature from RMD. The implementation is a little different, but functionality is pretty much the same. The most notable difference, but still minor, is that we don't store journal info in ScholarSphere, and journal matching in document metadata is a published version signal. We do hold publisher info, so I am using that instead.
Also, I added
unknownas an open access version value. This is useful to store if the version cannot be determined. It doesn't need to be an option users see, though.