Merged
Conversation
Fix credentials setup and update docs
# Conflicts: # Middleware/src/main/resources/application.properties
Prepare CITYdata for being served in a subpath
Fix/clean javadoc
Fix paths so they can be resolved correctly inside the jar
Fix GeoJSONProducer paths for correct resolution inside the jar
Fixed an file path resolution issue in JAR
CITYdata demo presentation + Architecture update
Architecture update
Java doc cleanup in entire project
Add docs folder to container for GeoJSONProducer file access
Updated Postman collection identifiers and descriptions for various requests.
nkinesis
reviewed
Mar 3, 2026
|
|
||
| /** | ||
| * This java class is to print all available routes | ||
| * This route prints CITYdata API end points |
Contributor
There was a problem hiding this comment.
Replace "end points" with "endpoints"
nkinesis
reviewed
Mar 3, 2026
| requestMappingInfo.getDirectPaths(); | ||
| final List<String> paths = requestMappingInfo.getDirectPaths().stream().toList(); // Simplified as Condition 'requestMappingInfo. getDirectPaths() != null' is always 'true' (Earlier -paths = requestMappingInfo.getDirectPaths() != null | ||
| requestMappingInfo.getDirectPaths(); | ||
| final List<String> paths = requestMappingInfo.getDirectPaths().stream().toList(); // Simplified as Condition 'requestMappingInfo. getDirectPaths() != null' is always 'true' (Earlier -paths = requestMappingInfo.getDirectPaths() != null |
nkinesis
approved these changes
Mar 3, 2026
Contributor
nkinesis
left a comment
nkinesis
left a comment
There was a problem hiding this comment.
Approved with a couple minor change recommendations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merging develop into master to deploy master.