Add data path configuration and moved data files#212
Conversation
There was a problem hiding this comment.
Is this related to IntelliJ?
There was a problem hiding this comment.
Some run/debug configuration related. I will remove it. It's not needed
| configured = configured.trim(); | ||
| if (configured.startsWith("~")) { | ||
| configured = configured.replaceFirst("^~", System.getProperty("user.home")); | ||
| } |
There was a problem hiding this comment.
Should it not return this computed path? java.nio.file.Paths.get(configured).toAbsolutePath().normalize();
There was a problem hiding this comment.
Yes just in case the path doesn't exist, I kept the fallback condition. But it's fine, I have updated the logic slightly to return this.
There was a problem hiding this comment.
Alright! I was trying to understand and I felt like the path has to be returned. Thanks for confirming.
Rushin-Makwana
force-pushed
the
setup-new-data-path
branch
from
03a7d25 to
55a371c
Compare
MinetteMeyo
left a comment
MinetteMeyo
left a comment
There was a problem hiding this comment.
PR looks good and works with BuildingProducer (I've pulled and tested it). Just a reminder: data files are in subfolders of Data/, so resolve the subfolder before accessing the file.
2 participants
Moved all the CSVs/ JSON Files to the Data folder which is now available in the parent directory( adjacent to Middleware Folder), added a data.path.route property in application.properties that now points to new Data Folder and updated AbstractProducer accordingly to get the data from this new path