fix: register missing harness-config import routes#186
Closed
scion-gteam[bot] wants to merge 2 commits into
Closed
fix: register missing harness-config import routes#186scion-gteam[bot] wants to merge 2 commits into
scion-gteam[bot] wants to merge 2 commits into
Conversation
The hub import screen returned HTTP 404 when importing harness-configs
because two routes were never wired up:
1. The unified `/api/v1/resources/import` endpoint handler existed but
was not registered in registerRoutes() — global-scope imports for
both templates and harness-configs were unreachable.
2. The per-project `/api/v1/projects/{id}/import-harness-configs`
endpoint had no backend route or handler (only import-templates
existed).
Add the missing route registration, implement the per-project
handleProjectImportHarnessConfigs handler, and add tests covering
global harness-config import, single-directory (leaf) import, and
per-project import.
The handleProjectImportHarnessConfigs handler was passing raw user input to importHarnessConfigsFromRemote without URL normalization, unlike the analogous template handler and the unified import endpoint which both call config.NormalizeTemplateSourceURL. This meant bare hostnames (e.g. "github.com/org/repo") would fail with a non-remote URI error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #185
/api/v1/resources/importendpoint inregisterRoutes()— it was defined but never wired up, so all global-scope resource imports (templates and harness-configs) returned 404import-harness-configssub-route inhandleProjectRouteswith a newhandleProjectImportHarnessConfigshandler, mirroring the existingimport-templatesendpointTest plan
TestHandleResourcesImport_HarnessConfigGlobal— unified endpoint withkind: harness-configandscope: globalTestHandleResourcesImport_SingleHarnessConfig— importing a single harness-config dir (leaf, not parent-of-dirs)TestHandleProjectImportHarnessConfigs— per-project endpointPOST /api/v1/projects/{id}/import-harness-configs