fix(ci): apply gofmt to fix format check on main#188
Closed
scion-gteam[bot] wants to merge 3 commits into
Closed
Conversation
…ain (GoogleCloudPlatform#371) * fix: route colocated docker agents to bridge networking via Caddy domain Colocated docker agents ran with --network=host, making the per-agent metadata server (127.0.0.1:18380) and telemetry OTLP receiver (:4317) host-global singletons. Only the first agent could bind them; concurrent or resumed agents got 'address already in use' -> sciontool doctor 502. Host networking also leaks GCP SA identity across agents. Route colocated docker agents at the public Caddy domain so each runs in its own netns under bridge networking: - ResolveDockerNetworking: add SCION_FORCE_HOST_NETWORK escape hatch; add DockerSupportsHostGateway capability probe (Engine >= 20.10). - startRuntimeBroker: ContainerHubEndpoint autocompute prefers the public domain for colocated docker; falls back to host.docker.internal (host networking) when force-host is set, host-gateway is unsupported, or no public domain is configured (warns in the latter two cases). - applyContainerBridgeOverride: use a public-domain ContainerHubEndpoint wholesale instead of grafting the localhost port (e.g. :8080) onto it. - gce-start-hub.sh: export SCION_SERVER_BASE_URL=https://${HUB_DOMAIN} so the broker dispatches agents to the domain. Scope is confined to docker + colocated; kubernetes, cloud run, podman, and remote-hub agents are unaffected. Reverting is a one-flag rollback (SCION_FORCE_HOST_NETWORK=1) with no redeploy. * fix: harden Docker host-gateway version probe per PR review - DockerSupportsHostGateway: bound the 'docker version' probe with a 5s timeout so an unresponsive daemon can't hang server startup. - parseDockerServerVersion: scan line-by-line and tolerate a leading v/V prefix so daemon warnings or prefixed versions don't defeat the probe. - add tests for v/V prefix, surrounding whitespace, and warning-prefixed multi-line output.
* docs: add release notes for June 6, 2026 * docs: add release notes for June 7, 2026 ---------
Owner
|
Merged upstream — PR GoogleCloudPlatform#373 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gofmt -won 7 files that are failing the CI Format Check step on upstream mainFixes #187
Files changed
cmd/sciontool/commands/init_crash_test.go— struct literal alignmentpkg/hub/lifecycle_hook_executor_test.go— trailing space in comment alignmentpkg/hub/server.go— struct field alignment + missing indentation onifstatementpkg/runtime/worktree_eligibility_test.go—namefield alignment in test casespkg/store/entadapter/composite.go—BrokerDispatchStorefield alignmentpkg/store/models.go— const block alignment + struct tag comment alignmentpkg/store/store.go— remove stray blank line before closing braceTest plan
gofmt -l .returns no output (all files formatted)go vet ./...passes