feat: ip-based verification#20
Merged
Merged
Conversation
SeverinAlexB
requested changes
Mar 25, 2026
Collaborator
There was a problem hiding this comment.
Not bad. Here are some findings:
Clean Code
I strongly recommend running my two clean-code/clean-refactor skills to find issues with the code structure on each PR:
- https://gist.github.com/SeverinAlexB/d717b26b28485f90e22c5b243e4065f4
- https://gist.github.com/SeverinAlexB/60b08a96701bd14b8bbc4282e8f76466
Prompt:
I need to do a code review of this PR. Use /clean-code and /clean-refactor to review the code accordingly
This gives me the following report:
https://gist.github.com/SeverinAlexB/2b2acdf286407dbe5493fd7da641fdbf
I think point 1 to 4 are valid points of improvement (not all caused by you). Others are up to your judgement.
OpenAI
openapi.yaml needs updating
2 tasks
… 404 if not enabled
86667
commented
Apr 27, 2026
SeverinAlexB
requested changes
Apr 27, 2026
Collaborator
SeverinAlexB
left a comment
There was a problem hiding this comment.
A few remaining things, otherwise it is good to go
… and homeserver availability checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a simply
/ip_verificationendpoint which creates users with ip-based rate limiting.refactor
Alongside the added endpoint we also implement 2 refactors:
x-forwarded-for. (Suggested here)