fix: add android elf build ids - #124
Merged
Merged
Conversation
This was referenced Jul 24, 2026
This comment was marked as outdated.
This comment was marked as outdated.
ovitrif
force-pushed
the
ovi/fix-paykit-android-build-ids
branch
from
July 26, 2026 20:47
56c5a4f to
155380f
Compare
ovitrif
requested review from
Jasonvdb and
dzdidi
and removed request for
ben-kaufman and
coreyphillips
July 27, 2026 13:46
ovitrif
marked this pull request as draft
July 27, 2026 14:31
This comment was marked as resolved.
This comment was marked as resolved.
ovitrif
force-pushed
the
ovi/fix-paykit-android-build-ids
branch
from
July 27, 2026 15:01
155380f to
02b2212
Compare
ovitrif
marked this pull request as ready for review
July 27, 2026 15:08
Jasonvdb
approved these changes
Jul 28, 2026
coreyphillips
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #121
Implements the Paykit producer portion of synonymdev/bitkit-android#1105.
Companion PRs:
Summary
-Wl,--build-id=sha1to the Android linker flags for all four published targets while preserving the existing linker flags0.1.0-rc40release with refreshed Android and Swift artifactsProtocol impact
None.
Downstream bindings
Android and Swift release artifacts are refreshed at
0.1.0-rc40. synonymdev/bitkit-android#1106 will adopt the released Paykit coordinate before merge.Checklist
cargo fmt --all -- --checkcargo clippy --workspace --all-targets --all-features --locked -- -D warningscargo test --workspace --all-features --lockedRUSTDOCFLAGS="-D warnings" cargo doc --workspace --no-deps --all-features --locked0.1.0-rc40Release
Review