Skip to content

fix: add android elf build ids - #124

Merged
ovitrif merged 1 commit into
masterfrom
ovi/fix-paykit-android-build-ids
Jul 28, 2026
Merged

fix: add android elf build ids#124
ovitrif merged 1 commit into
masterfrom
ovi/fix-paykit-android-build-ids

Conversation

@ovitrif

@ovitrif ovitrif commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Fixes #121

Implements the Paykit producer portion of synonymdev/bitkit-android#1105.

Companion PRs:

Summary

  • adds -Wl,--build-id=sha1 to the Android linker flags for all four published targets while preserving the existing linker flags
  • prepares the 0.1.0-rc40 release with refreshed Android and Swift artifacts

Protocol impact

None.

Downstream bindings

Android and Swift release artifacts are refreshed at 0.1.0-rc40. synonymdev/bitkit-android#1106 will adopt the released Paykit coordinate before merge.

Checklist

  • cargo fmt --all -- --check
  • cargo clippy --workspace --all-targets --all-features --locked -- -D warnings
  • cargo test --workspace --all-features --locked
  • RUSTDOCFLAGS="-D warnings" cargo doc --workspace --no-deps --all-features --locked
  • The all-platform release build completed for iOS and Android; Android publication used isolated Maven and Gradle state
  • Package metadata is consistently versioned 0.1.0-rc40
  • Platform release artifacts are refreshed
  • Two exact-head review passes completed with no actionable findings

Release

Review

  • One review is enough, there's similar work that was already done in the other rust-sources repos which was already approved.

@ovitrif

This comment was marked as outdated.

@ovitrif ovitrif closed this Jul 25, 2026
@ovitrif ovitrif reopened this Jul 25, 2026
@ovitrif
ovitrif force-pushed the ovi/fix-paykit-android-build-ids branch from 56c5a4f to 155380f Compare July 26, 2026 20:47
@ovitrif ovitrif changed the title fix: verify android elf build ids fix: add android elf build ids Jul 26, 2026
@ovitrif ovitrif self-assigned this Jul 27, 2026
@ovitrif
ovitrif requested review from Jasonvdb and dzdidi and removed request for ben-kaufman and coreyphillips July 27, 2026 13:46
@ovitrif
ovitrif marked this pull request as draft July 27, 2026 14:31
@ovitrif

This comment was marked as resolved.

@ovitrif
ovitrif force-pushed the ovi/fix-paykit-android-build-ids branch from 155380f to 02b2212 Compare July 27, 2026 15:01
@ovitrif
ovitrif changed the base branch from release/0.1.1 to master July 27, 2026 15:02
@ovitrif
ovitrif marked this pull request as ready for review July 27, 2026 15:08
@ovitrif
ovitrif requested a review from coreyphillips July 28, 2026 07:34
@ovitrif
ovitrif merged commit b6be4f6 into master Jul 28, 2026
8 checks passed
@ovitrif
ovitrif deleted the ovi/fix-paykit-android-build-ids branch July 28, 2026 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: add Android ELF build IDs

3 participants