Option for variable frame rates to download as GIF option#1611
Open
rishabhshuklax wants to merge 8 commits intopubliclab:mainfrom
Open
Option for variable frame rates to download as GIF option#1611rishabhshuklax wants to merge 8 commits intopubliclab:mainfrom
rishabhshuklax wants to merge 8 commits intopubliclab:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1611 +/- ##
==========================================
- Coverage 66.67% 65.41% -1.27%
==========================================
Files 130 132 +2
Lines 2686 2741 +55
Branches 433 438 +5
==========================================
+ Hits 1791 1793 +2
- Misses 895 948 +53 🚀 New features to boost your workflow:
|
Member
Author
|
@publiclab/is-reviewers please review this |
ataata107
reviewed
Feb 4, 2020
ataata107
reviewed
Feb 4, 2020
ataata107
approved these changes
Feb 10, 2020
harshkhandeparkar
added
the
almost-complete
|
|
harshkhandeparkar
approved these changes
Jul 12, 2020
harshkhandeparkar
added
ready-to-merge
and removed
almost-complete
harshkhandeparkar
requested changes
Oct 17, 2020
Member
harshkhandeparkar
left a comment
harshkhandeparkar
left a comment
There was a problem hiding this comment.
- The frame duration unit is not shown
- We should no allow any frame rate (-ve or too low etc)
Member
This could be merged if this is not a problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #743
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
npm run test-all@publiclab/is-reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!