Space and MessageType for publish and signal#76
Open
seba-aln wants to merge 8 commits into
Open
Conversation
seba-aln
requested review from
MikeDobrzan,
marcin-cebo and
mohitpubnub
as code owners
January 23, 2023 16:09
marcin-cebo
requested changes
Jan 24, 2023
seba-aln
force-pushed
the
feature/add-space-id-and-message-type
branch
from
February 7, 2023 14:58
7a2293d to
570b5e8
Compare
seba-aln
marked this pull request as draft
February 7, 2023 14:59
seba-aln
force-pushed
the
feature/add-space-id-and-message-type
branch
4 times, most recently
from
March 14, 2023 09:50
a8ddd9b to
3bc41f4
Compare
seba-aln
marked this pull request as ready for review
March 14, 2023 09:56
seba-aln
force-pushed
the
feature/add-space-id-and-message-type
branch
from
March 14, 2023 09:57
3bc41f4 to
debe66c
Compare
marcin-cebo
approved these changes
Mar 14, 2023
marcin-cebo
left a comment
marcin-cebo
left a comment
Contributor
There was a problem hiding this comment.
Nice.
One comment:
maybe I missed that but I think it would be valuable to have integration test(tests that calls real server) that verify that SpaceId and MessageType functionality works for each functionality: publish/subscribe, file, history, signal.
marcin-cebo
approved these changes
Mar 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.