Improve Security by Using Cryptographically Secure Random Numbers for IV Generation#191
Open
kexinoh wants to merge 2 commits intopubnub:masterfrom
Open
Improve Security by Using Cryptographically Secure Random Numbers for IV Generation#191kexinoh wants to merge 2 commits intopubnub:masterfrom
kexinoh wants to merge 2 commits intopubnub:masterfrom
Conversation
kexinoh
requested review from
jguz-pubnub,
seba-aln and
wkal-pubnub
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this pull request aims to enhance the security of the encryption process by replacing the non-cryptographically secure random number generation in the get_initialization_vector method with a cryptographically secure alternative.
While maintaining backward compatibility, the changes made in this PR focus on the following:
The use of random.randint for generating the initialization vector (IV) has been replaced with os.urandom to ensure that the IV is generated using a cryptographically secure random number generator.
The default static IV is retained to ensure backward compatibility with existing systems that may rely on this behavior. However, it is strongly recommended to use the new, cryptographically secure random IV generation for all new encryption operations.
These changes will help protect against potential vulnerabilities associated with predictable IVs without breaking existing functionality.