Skip to content

Partially implement flush for RFC2217#75

Merged
puddly merged 2 commits intodevfrom
puddly/rfc2217-flakiness-fix
May 4, 2026
Merged

Partially implement flush for RFC2217#75
puddly merged 2 commits intodevfrom
puddly/rfc2217-flakiness-fix

Conversation

@puddly
Copy link
Copy Markdown
Owner

@puddly puddly commented May 4, 2026

RFC2217 doesn't have a way to "flush". We instead "flush" the TCP socket by sending a no-op request and receiving a response.

test_fast_open_close as a test relies on behavior that not all backends technically have: enqueuing data to send and then closing the port only works on some backends.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 4, 2026

Codecov Report

❌ Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.73%. Comparing base (e062529) to head (ee9ef58).
⚠️ Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
serialx/platforms/serial_rfc2217/__init__.py 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #75      +/-   ##
==========================================
- Coverage   90.77%   90.73%   -0.04%     
==========================================
  Files          21       22       +1     
  Lines        3349     3367      +18     
==========================================
+ Hits         3040     3055      +15     
- Misses        309      312       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@puddly puddly merged commit 71c3b1d into dev May 4, 2026
38 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant