Skip to content

Move warning for missing Rust extension into function body#77

Merged
puddly merged 1 commit intodevfrom
puddly/move-missing-rust-into-call
May 4, 2026
Merged

Move warning for missing Rust extension into function body#77
puddly merged 1 commit intodevfrom
puddly/move-missing-rust-into-call

Conversation

@puddly
Copy link
Copy Markdown
Owner

@puddly puddly commented May 4, 2026

I've noticed the warning logs a bit more often than necessary. We currently do not rely on the Rust module for anything other than listing serial ports so this can be made into a loud runtime warning.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 4, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 90.70%. Comparing base (ff630dd) to head (e7f199a).

Files with missing lines Patch % Lines
serialx/serialx_rust.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #77      +/-   ##
==========================================
- Coverage   90.73%   90.70%   -0.03%     
==========================================
  Files          22       22              
  Lines        3367     3367              
==========================================
- Hits         3055     3054       -1     
- Misses        312      313       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@puddly puddly merged commit b091bc6 into dev May 4, 2026
38 of 40 checks passed
@puddly puddly deleted the puddly/move-missing-rust-into-call branch May 4, 2026 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant