Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ require (
github.com/spf13/cobra v1.6.1
github.com/spf13/pflag v1.0.5
github.com/stretchr/testify v1.8.4
github.com/zalando/go-keyring v0.2.3
github.com/zalando/go-keyring v0.2.5
golang.org/x/crypto v0.14.0
golang.org/x/sync v0.1.0
golang.org/x/term v0.13.0
Expand Down
4 changes: 2 additions & 2 deletions go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -170,8 +170,8 @@ github.com/yuin/goldmark v1.5.2 h1:ALmeCk/px5FSm1MAcFBAsVKZjDuMVj8Tm7FFIlMJnqU=
github.com/yuin/goldmark v1.5.2/go.mod h1:6yULJ656Px+3vBD8DxQVa3kxgyrAnzto9xy5taEt/CY=
github.com/yuin/goldmark-emoji v1.0.1 h1:ctuWEyzGBwiucEqxzwe0SOYDXPAucOrE9NQC18Wa1os=
github.com/yuin/goldmark-emoji v1.0.1/go.mod h1:2w1E6FEWLcDQkoTE+7HU6QF1F6SLlNGjRIBbIZQFqkQ=
github.com/zalando/go-keyring v0.2.3 h1:v9CUu9phlABObO4LPWycf+zwMG7nlbb3t/B5wa97yms=
github.com/zalando/go-keyring v0.2.3/go.mod h1:HL4k+OXQfJUWaMnqyuSOc0drfGPX2b51Du6K+MRgZMk=
github.com/zalando/go-keyring v0.2.5 h1:Bc2HHpjALryKD62ppdEzaFG6VxL6Bc+5v0LYpN8Lba8=
github.com/zalando/go-keyring v0.2.5/go.mod h1:HL4k+OXQfJUWaMnqyuSOc0drfGPX2b51Du6K+MRgZMk=
golang.org/x/crypto v0.0.0-20190308221718-c2843e01d9a2/go.mod h1:djNgcEr1/C05ACkg1iLfiJU5Ep61QUkGW8qpdssI0+w=
golang.org/x/crypto v0.0.0-20210921155107-089bfa567519/go.mod h1:GvvjBRRGRdwPK5ydBHafDWAxML/pGHZbMvKqRZ5+Abc=
golang.org/x/crypto v0.14.0 h1:wBqGXzWJW6m1XrIKlAH0Hs1JJ7+9KBwnIO8v66Q9cHc=
Expand Down
31 changes: 31 additions & 0 deletions 一pullpo一/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
# Pullpo Threaded Conversations on GitHub
## What is the 一pullpo一 directory I see on my project?
The directory allows your team to respond to comments that do not reference code in a
dedicated thread, instead of having to "quote reply" which makes following a conversation more
complex than it needs to be.

**DO NOT REMOVE OR .GITIGNORE THIS DIRECTORY OR THE AUTO-GENERATED FILES IT CONTAINS**. Doing so will
prevent you, your reviewers and ohter contributors from being able to have threaded messages in GitHub.
## What files does it contain?
The files inside this directory are created by a workflow (which you can probably find in )
that is executed when a new pull request is open in this repository. This file is added in a new commit to
your pull request. The **Pullpo GitHub App** transforms your normal comments into threaded comments by
commenting on this uniquely named file.
## Will this directory keep getting bigger and bigger?
No, the workflow removes all previous files in the directory. Since files have unique names within a
repository, this avoids merge conflicts and also prevents an infinetly increasing file list. If the
directory contains more than one file, it is likely because multiple pull requests were open at
the same time at one point.
## How will this appear on my Pull Request or tabs?
The tab will have the new threaded comments. Ideally you'll have
[logged into Pullpo](https://pullpo.io/login/github) with your GitHub account so the Pullpo App will be able
to replace the new comments as authored by you. Otherwise they will show up as an action that the bot made and
you'll be tagged in the new threaded comment.

As for the tab, the directory has been named by prefixing a
special character that sorts it to the bottom of the page, so all comment threads will sit at the bottom and
won't disturb anyone trying to read your changes.
## So, what now...?
Keep contributing as you're used to; your pull requests will receive an additional commit that enables
threaded comments. Other than that everything stays as usual.

Empty file added 一pullpo一/pr_9_threads.txt
Empty file.