-
Notifications
You must be signed in to change notification settings - Fork 14
example PR for showcasing comments #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mpl1018
wants to merge
1
commit into
main
Choose a base branch
from
mpl1018-patch-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -39,42 +39,6 @@ const DECORATIONS = [ | |
| { label: 'blocking', desc: 'Must be addressed before merge.', color: '#374151' }, // Dark Gray/Charcoal - Serious, indicates high importance/blocker | ||
| { label: 'if-minor', desc: 'Address if the effort is small.', color: '#14B8A6' } // Teal - Represents conditionality, distinct suggestion tone | ||
| ]; | ||
|
|
||
| // --- Selector for formatted Conventional Comments --- | ||
|
|
||
| const PLAIN_CC_REGEX = /^\s*(?:(praise|nitpick|suggestion|issue|question|thought|chore)\s*(?:\((non-blocking|blocking|if-minor)\))?:)\s*/; | ||
| const BADGE_CC_REGEX = /^\s*\[\!\[(?:(praise|nitpick|suggestion|issue|question|thought|chore)(?:\((non-blocking|blocking|if-minor)\))?)\]\(https?:\/\/img\.shields\.io\/badge\/.*?\)\]\(https?:\/\/pullpo\.io\/cc\?.*?\)\s*/; | ||
|
|
||
| // --- Global Couters --- | ||
|
|
||
| let toolbarCounter = 0; // Ensure unique IDs if multiple textareas load simultaneously | ||
| let settingsCounter = 0; // Unique IDs for settings elements | ||
|
|
||
| // --- Badge Helpers --- | ||
|
|
||
| // Helper function for badge colors using hex values | ||
| function getBadgeColor(type) { | ||
| // Find the label object | ||
| const label = LABELS.find(l => l.label === type); | ||
| // Return the color if found, otherwise default to gray | ||
| return label ? label.color.substring(1) : '6B7280'; // Remove # from hex color for shields.io | ||
| } | ||
|
|
||
| // Helper function to create badge markdown | ||
| function createBadgeMarkdown(type, decoration) { | ||
| // Get the label color (without #) | ||
| const labelColor = getBadgeColor(type); | ||
| let label = type; | ||
|
Comment on lines
-64
to
-67
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| let message = decoration || ''; // Use decoration as message if present | ||
| let decorationColor = ''; | ||
|
|
||
| // Get decoration color if a decoration is specified | ||
| if (decoration) { | ||
| const decorObj = DECORATIONS.find(d => d.label === decoration); | ||
| if (decorObj) { | ||
| decorationColor = decorObj.color.substring(1); // Remove # from hex color | ||
| } | ||
| } | ||
|
|
||
| let badgeUrl; | ||
|
|
||
|
|
@@ -532,4 +496,4 @@ document.addEventListener('visibilitychange', () => { | |
|
|
||
| processCommentAreas(); | ||
| } | ||
| }); | ||
| }); | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
congrats! This is a good one 👌