Open
Conversation
lukamac
force-pushed
the
lukamac/pr/refactor-network
branch
from
71abe5e to
30a99a9
Compare
Collaborator
|
I see that checks have failed. Please check that the modifications do not alternate the tests. Additionally, it would be needed in future to also add tests for GAP9 in the CI |
Collaborator
Author
|
Yes, I will fix the problems ofc. Regarding the gap9 tests in CI is a bit more difficult because we use the private gap_sdk. It is possible to add a test on our private gitlab, but it requires effort and time which I don't have right now. If anyone is interested in doing it, I can pass the info I have. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on drone code, we noticed that there was redundant code in the network run function so I moved some code to the initializer.
Alongside that I aligned a little bit more the common and gap9 network templates in hopes to merge them completely soon.