Conversation
niwis
requested changes
Nov 24, 2021
Collaborator
niwis
left a comment
niwis
left a comment
There was a problem hiding this comment.
Thanks for the PR! A few comments from my side.
src/fpga/pad_functional_xilinx.sv
Outdated
Comment on lines
50
to
60
| module pad_functional_pd | ||
| ( | ||
| input logic OEN, | ||
| input logic I, | ||
| output logic O, | ||
| input logic PEN, | ||
| inout logic PAD | ||
| ); | ||
|
|
||
| IOBUF iobuf_i ( | ||
| .T ( OEN ), |
Collaborator
There was a problem hiding this comment.
This is a redefinition of line 12. I guess this module definition should therefore be removed?
Author
There was a problem hiding this comment.
Sorry, there was an error on the name by copy and paste. It is "pad_functional" as in the deprecated module. I've fixed it
src/deprecated/pad_functional.sv
Outdated
Comment on lines
101
to
108
| OEN I PAD PEN | PAD O | ||
| | | ||
| 0 0 - 0/1 | 0 0 | ||
| 0 1 - 0/1 | 1 1 | ||
| 1 0/1 0 0/1 | - 0 | ||
| 1 0/1 1 0/1 | - 1 | ||
| 1 0/1 Z 0 | H H | ||
| 1 0/1 Z 1 | - X |
Collaborator
There was a problem hiding this comment.
Could you extend this table by the new input?
Co-authored-by: Nils Wistoff <nwistoff@iis.ee.ethz.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I put a padfunctional module with PU and PD signal control.
It might be useful to wrap tecnological pads.