Cleanup the workaround for skipping docs on nondefault branches#985
Merged
Conversation
pedro-psb
force-pushed
the
cleanup-docs-workflow
branch
from
c5a0adf to
47c14f0
Compare
pedro-psb
commented
Sep 25, 2025
|
|
||
| jobs: | ||
| changelog: | ||
| if: "endsWith(github.base_ref, '{{ plugin_default_branch }}')" |
Member
Author
There was a problem hiding this comment.
I think we still wanna assert the changes' fragments builds even on older branches
Contributor
|
pulp_rpm/#4161 is failing - is this PR ready for review, or is that failure telling us something? |
Member
Author
|
Let me have a look at this again |
auto-merge was automatically disabled
October 20, 2025 17:23
Pull request was converted to draft
We were skipping docs for non-default branches using a not very elegant solution. This standadizes the processes of doing job checks on ci.yml
pedro-psb
force-pushed
the
cleanup-docs-workflow
branch
from
47c14f0 to
5e1beca
Compare
Member
Author
|
Ok, now it's good. Indeed there was a problem with the implementation.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were skipping docs for non-default branches using a not very elegant solution. This standadizes the processes of doing job checks on ci.yml