Skip to content

Remove two small just-added tests #1188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dralley merged 2 commits into from
May 12, 2025
Merged

Remove two small just-added tests #1188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8bd0c87
Remove two small just-added tests
dralley May 8, 2025
d1bbf58
Fix a lint error caused by click deprecating __version__
dralley May 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .ci/scripts/check_click_for_mypy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,12 @@
#!/bin/env python3

import click
from importlib.metadata import version

from packaging.version import parse

if parse(click.__version__) < parse("8.1.1") or parse(click.__version__) >= parse("8.2"):
Copy link
Copy Markdown
Contributor Author

@dralley dralley May 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

click 8.2 was just released, our pyproject.toml only requests for <9, so this fails now

Copy link
Copy Markdown
Member

@mdellweg mdellweg May 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"This is the Click 8.2.0 feature release. A feature release may include new features, remove previously deprecated code, add new deprecation, or introduce potentially breaking changes."
AKA we don't use semver... AAAARGH

Copy link
Copy Markdown
Contributor Author

@dralley dralley May 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tbf they didn't actually remove it, but the warning alone caused our CI to fail

click_version = version("click")

if parse(click_version) < parse("8.1.1") or parse(click_version) >= parse("8.2"):
print("🚧 Linting with mypy is currently only supported with click~=8.1.1. 🚧")
print("🔧 Please run `pip install click~=8.1.1` first. 🔨")
exit(1)
6 changes: 0 additions & 6 deletions tests/scripts/pulp_rpm/test_rpm_sync_publish.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,12 +106,6 @@ then

expect_succ pulp rpm repository update --name "cli_test_rpm_repository" --checksum-type sha512
expect_fail pulp rpm repository update --name "cli_test_rpm_repository" --checksum-type sha1

if pulp debug has-plugin --name "rpm" --specifier ">=3.30.0"
then
expect_fail pulp rpm repository update --name "cli_test_rpm_repository" --package-checksum-type sha256
expect_fail pulp rpm repository update --name "cli_test_rpm_repository" --metadata-checksum-type sha256
fi
else
expect_succ pulp rpm repository update --name "cli_test_rpm_repository" --metadata-checksum-type sha1
expect_succ pulp rpm repository update --name "cli_test_rpm_repository" --package-checksum-type sha1
Expand Down
Loading