Clean up evr_t remnants#4467
Open
dralley wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
the
multi-commit
github-actions
Bot
removed
the
multi-commit
mdellweg
reviewed
May 26, 2026
Assisted-By: claude-opus-4.6
dralley
changed the title
dralley
commented
Jun 3, 2026
| cleanup_sql = """ | ||
| -- Drop old triggers (will be recreated below) | ||
| DROP TRIGGER IF EXISTS pulp_evr_insert_trigger ON rpm_package; | ||
| DROP TRIGGER IF EXISTS pulp_evr_update_trigger ON rpm_package; |
Contributor
Author
There was a problem hiding this comment.
Is there a race condition window between here and line 40 that we need to be concerned about when it comes to ZDT upgrades?
Member
There was a problem hiding this comment.
It runs in a migration. So we could add a table lock be be extra sure.
Probably "SHARE ROW EXCLUSIVE" is a good choice, since it will be acquired by the "CREATE TRIGGER" commands anyway.
To prevent races between different pulp_rpm releases, we use the pulpcore.migrations.RequireVersion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cannot merge until next release