Get tests to run w/ our latest version of NodeJS#5
Merged
confused-Techie merged 2 commits intomasterfrom Feb 17, 2026
Merged
Conversation
This was referenced Feb 16, 2026
Merged
DeeDeeG
approved these changes
Feb 17, 2026
Member
DeeDeeG
left a comment
DeeDeeG
left a comment
There was a problem hiding this comment.
Seems to be working as intended!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Over in
pulsar-edit#1436we were discussing how to minimize the amount of places we have to define the latest version of NodeJS that Pulsar is on, and thus that we want to ensure we are testing against in everything.My idea was to define an organization level variable that we could easily update with the latest version of NodeJS, and savetheclocktower helpfully suggested we also make sure to leave the last known good version as well.
So this PR attempts this, defining a matrix of tests, with the last known good version for the repo, in this case
v14, and gets the version from a new organization level actions variable I've made, definingv20.11.1.So lets see if this works the way we want it too.