Merged
Conversation
Member
Author
|
Sorry my bad, didn't mean to include all other bumps here, suppose that means that #7 should likely be merged on it's own first, then this one can be fully evaluated of it's own merit. |
DeeDeeG
approved these changes
Feb 18, 2026
Member
DeeDeeG
left a comment
There was a problem hiding this comment.
I've reviewed #7 just now, the remaining changes focused on tar look good here, nothing too too crazy. Small diff, IMO.
You'll notice I was very careful to not touch any of the specs here, so we can be confident in these code changes keeping the exact same outside behavior.
Indeed, this is nice to see! LGTM. 👍
Member
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While I intended to bump all dependencies in #7, unfortunately bumping the
tardependency was rather involved, as that code base has seen lots of changes in the meantime.In this PR when bumping
tarto the latest I had to make a few code changes:tarnow gives us strings instead of string-like numbers for types.Parsefunction directly no longer works, the modern equivalent ist().strictoption, astarnow automatically recovers from these situations.pathandtypevalues are now at the root of anentryobjectYou'll notice I was very careful to not touch any of the specs here, so we can be confident in these code changes keeping the exact same outside behavior.