Bump @pulsar-edit/superstring to 3.0.5#1441
Merged
savetheclocktower merged 1 commit intomasterfrom Feb 16, 2026
Merged
Conversation
This is the fix for the crasher sometimes triggered by calling `TextBuffer::findWordsWithSubsequence` and `TextBuffer::setTextInRange` in rapid succession. Instead of bumping everything that uses `superstring`, we'll use `resolutions` in `package.json` to ensure that all dependencies are aligned on the version of `superstring` being used. We can do proper version bumps on other packages as needed.
Closed
confused-Techie
approved these changes
Feb 16, 2026
Member
confused-Techie
left a comment
confused-Techie
left a comment
There was a problem hiding this comment.
Standard macOS failures.
But LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1438.
This is the fix for the crasher sometimes triggered by calling
TextBuffer::findWordsWithSubsequenceandTextBuffer::setTextInRangein rapid succession. We reproduced the crash and fixed it in superstring#21, then published3.0.5to NPM.Instead of bumping everything that uses
superstring, we'll useresolutionsinpackage.jsonto ensure that all dependencies are aligned on the version ofsuperstringbeing used. We can do proper version bumps on those other packages as occasions present themselves.