Skip to content

Update to a version of pathwatcher…#1471

Merged
savetheclocktower merged 2 commits intomasterfrom
alternative-pathwatcher-impl
Mar 14, 2026
Merged

Update to a version of pathwatcher…#1471
savetheclocktower merged 2 commits intomasterfrom
alternative-pathwatcher-impl

Conversation

@savetheclocktower
Copy link
Copy Markdown
Contributor

@savetheclocktower savetheclocktower commented Mar 1, 2026 •
edited
Loading

…that uses kqueue on macOS instead of FSEvents.

If all goes well, this could fix #1459. At the very least, it should return pathwatcher behavior to something much closer to what it was before we had to rewrite it.

Opened as a draft for now; those affected by #1459 can try the binaries produced by this PR’s CI job.

(node-pathwatcher#4 has some background on this change.)

@savetheclocktower
Experiment with a version of pathwatcher…
3da01b7 
…that uses `kqueue` on macOS instead of `FSEvents`. This might fix #1459.
This was referenced Mar 1, 2026
Closed
Open
@savetheclocktower savetheclocktower force-pushed the alternative-pathwatcher-impl branch from 84f5a9a to 3da01b7 Compare March 4, 2026 02:52
DeeDeeG
DeeDeeG reviewed Mar 13, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@DeeDeeG DeeDeeG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 just stopping by to give a lite positive indication from me to say pulsar-edit/node-pathwatcher#4 seems to have gone well, and so this should probably proceed past a draft.

@savetheclocktower
Copy link
Copy Markdown
Contributor Author

savetheclocktower commented Mar 13, 2026 •
edited
Loading

Yeah, in a bit I'll put out a new pathwatcher NPM release.

Ordinarily I'd want to bump this dependency the proper way, but pathwatcher is used by several of our dependencies, and I don't want to go through the trouble of issuing new patch releases for everything that depends on pathwatcher. Hence the override route. The new PR will look a lot like this one, except the new field in resolutions will point to a version number instead of a Git commit. (EDIT: Reusing this PR instead of opening a new one.)

@savetheclocktower savetheclocktower changed the title Experiment with a version of pathwatcher… Update to a version of pathwatcher… Mar 13, 2026
@savetheclocktower savetheclocktower added this to the 1.131.2 milestone Mar 13, 2026
@savetheclocktower savetheclocktower marked this pull request as ready for review March 14, 2026 02:58
@savetheclocktower
Copy link
Copy Markdown
Contributor Author

savetheclocktower commented Mar 14, 2026

OK, this bump was approved back in the node-pathwatcher repo, and CI is green. Landing now!

@savetheclocktower savetheclocktower merged commit 87d7eac into master Mar 14, 2026
198 of 199 checks passed
savetheclocktower added a commit that referenced this pull request Mar 14, 2026
@savetheclocktower
Update to a version of pathwatcher… (#1471)
cd8c7ea 
* Experiment with a version of `pathwatcher`…

…that uses `kqueue` on macOS instead of `FSEvents`. This might fix #1459.

* Pin to `pathwatcher@9.0.3`
@savetheclocktower savetheclocktower deleted the alternative-pathwatcher-impl branch March 16, 2026 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DeeDeeG DeeDeeG DeeDeeG left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.131.2

Development

Successfully merging this pull request may close these issues.

File changes made by external programs are no longer reflected in real-time since 1.131

2 participants

@savetheclocktower @DeeDeeG