Draft
Conversation
…when detected changes to the backing file match what's in the buffer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(This builds on work done in #11; I'll keep this PR in draft until that one lands.)
Issue or RFC Endorsed by Atom's Maintainers
#12
Description of the Change
This improves handling of a “deleted” buffer state as follows:
isDeletedis now a state that can be queried just likeisModifiedorisInConflict.isModifiedso that it no longer automatically returnstrueif the buffer's file doesn't exist. Instead, it returnsfalseif the buffer was unmodified at time of deletion, as long as no subsequent edits have been made. Otherwise, it returnstruein all scenarios in which it would've previously returnedtrue.This allows us to get closer to VS Code's behavior with deleted files: allow the user to remove their tab from the workspace without an unnecessary “are you sure?” prompt.
Alternate Designs
#12 outlines the two possible designs. I went with the first one because it's more elegant.
Possible Drawbacks
There could be unintended side effects of narrowing the definition of
isModifiedfor one specific kind of pane item. I haven't found any yet, but we should keep an eye on this.Verification Process
New unit tests.
Release Notes