feat: add PinnedHttpClient with shared TLS config #39
+430
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avrabe
force-pushed
the
feat/pinned-http-client
branch
2 times, most recently
from
2d6c95c to
62db2fd
Compare
Add certificate pinning support to the HTTP abstraction layer: - Extract create_pinned_rustls_config() as shared function for both sync (ureq) and async (reqwest) HTTP clients - Add PinnedHttpClient that enforces certificate pinning using the shared rustls config - Refactor transport.rs to use the shared TLS configuration - Update signer.rs to use check_pinning_requirement instead of deprecated check_pinning_enforcement - Clean up exports in keyless mod.rs - Fix cfg guards for WASM/WASI targets This enables consistent certificate pinning behavior across sync and async HTTP clients, preparing for async HTTP support when needed.
avrabe
force-pushed
the
feat/pinned-http-client
branch
from
62db2fd to
c68e4fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add certificate pinning support to the HTTP abstraction layer:
create_pinned_rustls_config()as shared function for both sync (ureq) and async (reqwest) HTTP clientsPinnedHttpClientthat enforces certificate pinning using the shared rustls configtransport.rsto use the shared TLS configurationsigner.rsto usecheck_pinning_requirementinstead of deprecatedcheck_pinning_enforcementmod.rsThis enables consistent certificate pinning behavior across sync and async HTTP clients, preparing for async HTTP support when needed.
Test plan
cargo test --package wsc --lib)