Skip to content

Add new User Agents for iPhone and iPad; Fix vertical alignment of online indicator#77

Open
m-mikapika wants to merge 10 commits intopupgray:mainfrom
m-mikapika:main
Open

Add new User Agents for iPhone and iPad; Fix vertical alignment of online indicator#77
m-mikapika wants to merge 10 commits intopupgray:mainfrom
m-mikapika:main

Conversation

@m-mikapika
Copy link

@m-mikapika m-mikapika commented May 24, 2025

  • I have added two new User Agents,

    • 'WalltakeriOS-iPhone-Shortcut (mikapika.)'
    • 'WalltakeriOS-iPad-Shortcut (mikapika.)'.
    • This is because I have created a method of using the Shortcuts app to set Walltaker wallpapers.
  • I have changed the vertical alignment of the online indicator on the profile to be centred with the username.

Also I apologise for multiple different changes from the same pull request. I am new to actually using GitHub on public repositories.

Added 'WalltakeriOS-iPhone-Shortcut (mikapika.)' and 'WalltakeriOS-iPad-Shortcut (mikapika.)' to link_agent_to_icon.

This is because I have created a way to use Walltaker on iOS devices using the Shortcuts app.
Added ios_iphone and ios_ipad to devices, which use mobile and desktop respectively.

This is because I have created a way to use Walltaker from an iOS device using the Shortcuts app.
Fix vertical alignment of online indicator
Fix vertical alignment of online indicator
@pupgray
Copy link
Owner

pupgray commented May 24, 2025

Thank you so much!! Happy to accept this as-is!

Though, as it stands, this will essentially remove the icon for the client on links that match your clients.

<% case link_agent_to_icon link.last_ping_user_agent %>

If you'd like a specific icon, it'll need to be included in this big ol' case expression ⬆️

<% when :ios_iphone %>
          <span>Any short word here!</span>
          <iconify-icon icon="..."></iconify-icon>
<% when :ios_ipad %>
          <span>Any short word here!</span>
          <iconify-icon icon="..."></iconify-icon>

<iconify-icon icon="iconnamehere"></iconify-icon> will match ANY icon from this site: https://icon-sets.iconify.design/ (it's a rather clever web component, only pulls down the single icon when needed, so don't worry about picking an icon from a icon set we don't use, the load impact is quite low!)

Capture d’écran, le 2025-05-24 à 17 28 49

Change name of devices for iPhone and iPad
Moved devices up above :ioswidget and :switft
Renamed devices to iphone_shortcuts and ipad_shortcuts
Moved devices to above :ioswidget and :swift
Added iphone_shortcuts and ipad_shortcuts icons
@m-mikapika
Copy link
Author

Changes made and icons added!

Regarding how it pings Walltaker, it's just a HTTP GET request within the Shortcuts app.
It does let you choose the headers yourself, but I don't know if anything else is put onto it when it's sent.

Either way they're moved so should be fine 👍

@m-mikapika m-mikapika requested a review from pupgray May 29, 2025 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants