(P4DEVOPS-9434) Wire RateLimiter middleware into API Rack stack#696
Merged
(P4DEVOPS-9434) Wire RateLimiter middleware into API Rack stack#696
Conversation
mahikalra
approved these changes
Mar 19, 2026
This was referenced Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
RateLimitermiddleware was implemented inlib/vmpooler/api/rate_limiter.rbas part of P4DEVOPS-9434 but was never wired into the Rack middleware stack inlib/vmpooler/api.rb. As a result,rate_limiting_enabled: truein the vmpooler config had no effect — all requests passed through without rate limit checks.This was discovered during dev environment testing where 105 rapid requests returned HTTP 200 instead of HTTP 429.
Fix
rate_limiterto the list of required API componentsuse Vmpooler::API::RateLimiter, redis, configinto the Rack stack whenrate_limiting_enabledistruein configTesting
Verified in dev (
https://vmpooler-dev.k8s.infracore.puppet.net):X-RateLimit-Limit,X-RateLimit-Remaining,Retry-AfterheadersRelated