Skip to content

util: Add DownloadFile function#790

Closed
ahmad-abuziad wants to merge 1 commit intopurpleidea:masterfrom
ahmad-abuziad:http-download-resource
Closed

util: Add DownloadFile function#790
ahmad-abuziad wants to merge 1 commit intopurpleidea:masterfrom
ahmad-abuziad:http-download-resource

Conversation

@ahmad-abuziad
Copy link
Copy Markdown
Contributor

Enhancement

  • automatically create directories if don't exist, now it fails if any directory doesn't exist in the filePath
  • if filePath is empty string, create a file with random name under tmp directory and return a string(path to the file)
  • parameter named to filePath with capital P to avoid confusion with the filepath package

@ahmad-abuziad ahmad-abuziad changed the title utl: add DownloadFile function util: add DownloadFile function Feb 10, 2025
@ahmad-abuziad ahmad-abuziad force-pushed the http-download-resource branch 2 times, most recently from ed9faed to 08cf287 Compare February 11, 2025 14:39
@ahmad-abuziad ahmad-abuziad changed the title util: add DownloadFile function util: Add DownloadFile function Feb 11, 2025
@ahmad-abuziad ahmad-abuziad marked this pull request as ready for review February 11, 2025 14:40
@ahmad-abuziad ahmad-abuziad marked this pull request as draft February 11, 2025 14:43
@ahmad-abuziad ahmad-abuziad marked this pull request as ready for review February 11, 2025 15:01
@ahmad-abuziad
Copy link
Copy Markdown
Contributor Author

@purpleidea please review

@purpleidea
Copy link
Copy Markdown
Owner

Where is this utility function being used?

@purpleidea
Copy link
Copy Markdown
Owner

Closed b/c stale.

@purpleidea purpleidea closed this Feb 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants