Skip to content

Modular UI/small screen fix #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benjamsf merged 2 commits into from
Feb 8, 2026
Merged

Modular UI/small screen fix #120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d13c2ba
fix: layout on small devices
logaritmi Feb 8, 2026
435b54d
chore: bump version
logaritmi Feb 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .bumpversion.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[bumpversion]
current_version = 1.10.1
current_version = 1.10.2
commit = False
tag = False

Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "takrmapi"
version = "1.10.1"
version = "1.10.2"
description = "RASENMAEHER integration API for TAK server"
authors = ["Eero af Heurlin <rambo@iki.fi>", "Ari Karhunen <FIXME@example.com>"]
homepage = "https://github.com/pvarki/python-tak-rmapi"
Expand Down
2 changes: 1 addition & 1 deletion src/takrmapi/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
"""RASENMAEHER integration API for TAK server"""

__version__ = "1.10.1" # NOTE Use `bump2version --config-file patch` to bump versions correctly
__version__ = "1.10.2" # NOTE Use `bump2version --config-file patch` to bump versions correctly
2 changes: 1 addition & 1 deletion tests/test_takrmapi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@

def test_version() -> None:
"""Make sure version matches expected"""
assert __version__ == "1.10.1"
assert __version__ == "1.10.2"


@pytest.fixture(autouse=True)
Expand Down
13 changes: 6 additions & 7 deletions ui/src/components/instructions/onboarding/OnboardingHandler.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,7 +322,6 @@ export function OnboardingHandler() {

const handleOpenChange = useCallback((newOpen: boolean) => {
setOpen(newOpen);
// Don't auto-complete steps when just closing the dialog
}, []);

const handleNext = () => {
Expand Down Expand Up @@ -360,8 +359,8 @@ export function OnboardingHandler() {
const imageUrl = isMobile && step.mobileImage ? step.mobileImage : step.image;

const contentComponent = (
<div className="flex flex-col h-full max-h-[90vh]">
<div className="flex-1 overflow-y-auto p-4 md:p-6 space-y-6">
<div className="flex flex-col h-full max-h-[85vh] w-full overflow-hidden">
<div className="flex-1 overflow-y-auto min-h-0 p-4 md:p-6 space-y-6">
<div className="space-y-1">
<h2 className="text-xl font-bold leading-tight">{t(step.title)}</h2>
<p className="text-xs text-muted-foreground uppercase tracking-wider font-semibold">
Expand Down Expand Up @@ -421,7 +420,7 @@ export function OnboardingHandler() {

<div
className={cn(
"relative rounded-xl overflow-hidden aspect-video w-full border border-border shadow-sm bg-muted/20",
"relative rounded-xl overflow-hidden aspect-video w-full border border-border shadow-sm bg-muted/20 shrink-0",
!imageError && !imageLoading && "cursor-pointer",
)}
onClick={() => !imageError && !imageLoading && setImageEnlarged(true)}
Expand Down Expand Up @@ -457,7 +456,7 @@ export function OnboardingHandler() {
</div>
</div>

<div className="p-4 border-t bg-background flex gap-3">
<div className="p-4 border-t bg-background flex gap-3 shrink-0 mt-auto">
<Button
variant="outline"
onClick={() => currentStep > 0 && setCurrentStep((c) => c - 1)}
Expand All @@ -477,7 +476,7 @@ export function OnboardingHandler() {
</Button>
</div>

<div className="h-1.5 w-full bg-muted">
<div className="h-1.5 w-full bg-muted shrink-0">
<div
className="h-full bg-primary-light transition-all duration-500 ease-out"
style={{ width: `${progress}%` }}
Expand Down Expand Up @@ -524,7 +523,7 @@ export function OnboardingHandler() {
</Drawer>
) : (
<Dialog open={open} onOpenChange={handleOpenChange}>
<DialogContent className="max-w-2xl p-0 overflow-hidden outline-none">
<DialogContent className="max-w-2xl max-h-[90vh] p-0 flex flex-col overflow-hidden outline-none">
{contentComponent}
</DialogContent>
</Dialog>
Expand Down