β‘ Bolt: Optimize StringEncoder with direct encodeInto #43
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π‘ What: Optimized
StringEncoder.encodeto utilizeTextEncoder.prototype.encodeIntodirectly into the destination buffer when available. Removed unnecessary intermediate buffer management code.π― Why: The previous implementation created an intermediate
ArrayBufferandUint8Array, encoded the string into it, and then copied the result to the destination. This resulted in double allocation and copying, slowing down string encoding significantly.π Impact:
set(copy) operation.Note: This change relies on the caller providing a destination buffer that is large enough to hold the encoded string (which
ShareableArrayguarantees by allocatingmaximumLength). If the buffer were too small,encodeIntowould truncate rather than throw, but in this codebase's context, the size is pre-calculated safely.PR created automatically by Jules for task 1750894744571246857 started by @pverscha