β‘ Optimize ShareableArray.unshift and addOrSetItem #45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π‘ What: Replaced manual shifting loops in
ShareableArray.unshift,deleteItem, andaddOrSetItemwithUint8Array.prototype.copyWithin. RefactoredaddOrSetItemto handle in-place replacement efficiently without unnecessary shift-left then shift-right operations.π― Why: Manual loop shifting is slow in JS compared to native memmove. The original replacement logic was O(N) due to double shifting, making operations like
unshiftO(N*K). The optimization makes replacement O(1) (excluding allocation) and shifting O(N) native.π Measured Improvement: Benchmark shows
unshiftperformance improved from ~1.64ms to ~0.015ms (>100x speedup) for adding 10 items to a 10,000 element array.PR created automatically by Jules for task 2911820460188290781 started by @pverscha