Skip to content

Conversation

@google-labs-jules
Copy link

⚡ Bolt: Optimize ShareableMap defragmentation

💡 What: Replaced the manual byte-by-byte copy loop in ShareableMap.defragment with Uint8Array.prototype.set combined with subarray.

🎯 Why: The manual loop was suboptimal for copying larger blocks of memory. Using the native memcpy via set is significantly faster for larger payloads.

📊 Impact: Reduces defragmentation time by ~66% (3x faster) for items around 1KB in size. For very small items (<50 bytes), performance is neutral.

🔬 Measurement: Verified using a custom benchmark script (bench_defrag.ts) creating a 5000-item map with 1KB values, deleting 50% to trigger defragmentation.

  • Before: ~24.6ms
  • After: ~8.35ms

PR created automatically by Jules for task 13140758725918940722 started by @pverscha

- Replaces manual byte-by-byte copy loop with `Uint8Array.prototype.set` utilizing `subarray`.
- Achieves ~66% performance improvement (approx 3x faster) for large items (1KB).
- Reduces execution time from ~24.6ms to ~8.35ms in benchmark.
@google-labs-jules
Copy link
Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant