Skip to content

add support for zero gcr in bifacial.infinite_sheds and shading.masking_angle - #1589

Merged
kandersolar merged 3 commits into
pvlib:mainfrom
kdebrab:gcr_zero
Nov 11, 2022
Merged

add support for zero gcr in bifacial.infinite_sheds and shading.masking_angle#1589
kandersolar merged 3 commits into
pvlib:mainfrom
kdebrab:gcr_zero

Conversation

@kdebrab

@kdebrab kdebrab commented Nov 11, 2022

Copy link
Copy Markdown
Contributor
  • Closes ZeroDivisionError when gcr is zero #1576
  • I am familiar with the contributing guidelines
  • Tests added
  • Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

@cwhanse cwhanse added this to the 0.9.4 milestone Nov 11, 2022

@cwhanse cwhanse left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kdebrab

@kandersolar kandersolar changed the title add support for zero gcr add support for zero gcr in bifacial.infinite_sheds and shading.masking_angle Nov 11, 2022

@kandersolar kandersolar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kandersolar
kandersolar merged commit eefc35c into pvlib:main Nov 11, 2022
@kdebrab
kdebrab deleted the gcr_zero branch November 12, 2022 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ZeroDivisionError when gcr is zero

3 participants